[coreboot-gerrit] Change in coreboot[master]: src/soc/intel: Add support for pmc core driver

[Venkata Krishna Nimmagadda (Code Review)]

Venkata Krishna Nimmagadda has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39370 )

Change subject: src/soc/intel: Add support for pmc core driver
......................................................................

Patch Set 5: Code-Review+1

(2 comments)

https://review.coreboot.org/c/coreboot/+/39370/3/src/soc/intel/common/acpi/p... 
File src/soc/intel/common/acpi/pmc.asl:

https://review.coreboot.org/c/coreboot/+/39370/3/src/soc/intel/common/acpi/p... 
PS3, Line 21: PPD0
> Can you please point me to the kernel driver using this? What is the format of this Package being ex […]

I could not find anything using this. I have updated the patch now. Thanks

https://review.coreboot.org/c/coreboot/+/39370/4/src/soc/intel/common/acpi/p... 
File src/soc/intel/common/acpi/pmc.asl:

https://review.coreboot.org/c/coreboot/+/39370/4/src/soc/intel/common/acpi/p... 
PS4, Line 23: "\_SB.PC00.SAT0"
> What is this path supposed to be pointing to? I don't see any device generated anywhere that has thi […]

Thanks for pointing it out.I could not find anything using this or this reference existing. I have updated the patch.