Thejaswani Putta has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36654 )
Change subject: libpayload: keyboard: Ignore special keys ......................................................................
Patch Set 11:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/driver... File payloads/libpayload/drivers/usb/usbhid.c:
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/driver... PS10, Line 32: #include <libpayload.h>
why change this?
Reverted as it is not required anymore.
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/includ... File payloads/libpayload/include/libpayload.h:
https://review.coreboot.org/c/coreboot/+/36654/10/payloads/libpayload/includ... PS10, Line 68: #include <keycodes.h>
is this needed?
Yes, all the keyboard macros are declared in keycodes.h, this header is included here so that libpayload will have all that macro definitions required in depthcharge for the fn(keyboard_media_key_mapping).