Attention is currently required from: Ana Carolina Cabral, Felix Held, Paul Menzel.
Patrick Rudolph has posted comments on this change by Patrick Rudolph. ( https://review.coreboot.org/c/coreboot/+/86385?usp=email )
Change subject: device/pci_rom: Keep track of VBIOS
......................................................................
Patch Set 3:
(2 comments)
File src/device/pci_rom.c:
https://review.coreboot.org/c/coreboot/+/86385/comment/03ee3dd5_f3aa17cf?usp... :
PS3, Line 172: #if CONFIG(HAVE_ACPI_TABLES)
when removing the guard in the header file, those guards can be dropped too, since this will still b […]
Done
File src/include/device/device.h:
https://review.coreboot.org/c/coreboot/+/86385/comment/9e56b010_37ed3ce0?usp... :
PS3, Line 131: #if CONFIG(HAVE_ACPI_TABLES)
hmm, i don't see the need to put this in a #if CONFIG(HAVE_ACPI_TABLES) block and iirc i removed som […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86385?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib27d30e3b07740d6098d4f7a5c4f5d8bce976f00
Gerrit-Change-Number: 86385
Gerrit-PatchSet: 3
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 20 Feb 2025 12:51:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de