Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39509 )
Change subject: util/inteltool: powermgt: add code for dumping config registers
......................................................................
Patch Set 4: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/39509/4/util/inteltool/powermgt.c
File util/inteltool/powermgt.c:
https://review.coreboot.org/c/coreboot/+/39509/4/util/inteltool/powermgt.c@6...
PS4, Line 674: pm_cfg_registers_size
Are you initializing this anywhere?
https://review.coreboot.org/c/coreboot/+/39509/4/util/inteltool/powermgt.c@6...
PS4, Line 680: printf("\n========== ACPI/PMC =========\n\n");
Why the rename?
https://review.coreboot.org/c/coreboot/+/39509/4/util/inteltool/powermgt.c@8...
PS4, Line 871: for (i = 0; i < pm_cfg_registers_size; i++) {
Why not use a separate function?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39509
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic78f847ba07240c112492229f9a23f9a88275ad9
Gerrit-Change-Number: 39509
Gerrit-PatchSet: 4
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 14 Mar 2020 21:34:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment