Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41943 )
Change subject: sb/intel/lynxpoint: Clean up code ......................................................................
Patch Set 6: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/early_usb.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 27: pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER | PCI_COMMAND_MEMORY); Off-topic; check if there is errata about _MASTER being compulsory for _MEMORY to take effect on some revision.
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/elog.c:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 33: u32 gpe0_en = inl(get_pmbase() + gpe0_en_reg); This even (space) looks odd to me. Pun intended.
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/lp_gpio.h:
https://review.coreboot.org/c/coreboot/+/41943/6/src/southbridge/intel/lynxp... PS6, Line 155: /* Get GPIO pin value */ Is this and the comment above worth a period at the end?