Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35164 )
Change subject: soc/mediatek/mt8183: Use cached calibration result for faster bootup
......................................................................
Patch Set 37:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35164/35/src/soc/mediatek/mt8183/in...
File src/soc/mediatek/mt8183/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/35164/35/src/soc/mediatek/mt8183/in...
PS35, Line 24: DRAMC_PARAM_SOURCE_SDRAM_CONFIG = 0,
: DRAMC_PARAM_SOURCE_FLASH,
Since you are declaring this as u16, you already need to consider any unexpected values. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35164
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9ef4265dd369a1c276bb02294696556df927e7bc
Gerrit-Change-Number: 35164
Gerrit-PatchSet: 37
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Huayang Duan
huayang.duan@mediatek.corp-partner.google.com
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Oct 2019 04:31:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Hung-Te Lin
hungte@chromium.org
Gerrit-MessageType: comment