Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32252 ) Change subject: mb/intel/icelake_rvp: Add SMI handlers ...................................................................... Patch Set 3: (3 comments) https://review.coreboot.org/#/c/32252/3//COMMIT_MSG Commit Message: https://review.coreboot.org/#/c/32252/3//COMMIT_MSG@7 PS3, Line 7: mb/intel/icelake_rvp: Add SMI handlers Is it Chrome EC specific?
Add SMI handlers for Chrome EC
https://review.coreboot.org/#/c/32252/3//COMMIT_MSG@11 PS3, Line 11: 1. eSPI SMI event. Please remove the dot at the end. https://review.coreboot.org/#/c/32252/3//COMMIT_MSG@15 PS3, Line 15: Sleep(S3/S5) Please add a space before (. -- To view, visit https://review.coreboot.org/c/coreboot/+/32252 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Ibc0284b99bb2f4807ff2c0ec90b316730b251ddb Gerrit-Change-Number: 32252 Gerrit-PatchSet: 3 Gerrit-Owner: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Aamir Bohra <aamir.bohra@intel.com> Gerrit-Reviewer: Martin Roth <martinroth@google.com> Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com> Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com> Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Tue, 09 Apr 2019 13:30:15 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment