Attention is currently required from: Sean Rhodes, Felix Held.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56088 )
Change subject: mainboard/starlabs: Add StarBook Mk V
......................................................................
Patch Set 116: Code-Review+2
(2 comments)
File Documentation/mainboard/starlabs/BiosLock.jpg:
PS109:
Done
Ack
File src/mainboard/starlabs/labtop/acpi/mainboard.asl:
https://review.coreboot.org/c/coreboot/+/56088/comment/647998b2_38cf8bd1
PS109, Line 25: "PRP00001"
It does!
I see you've updated the ID to match the required format. I guess it's good enough for now.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56088
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I090971a9e8d2be5b08be886d00d304607304b645
Gerrit-Change-Number: 56088
Gerrit-PatchSet: 116
Gerrit-Owner: Sean Rhodes
admin@starlabs.systems
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andy Pont
andy.pont@sdcsystems.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes
admin@starlabs.systems
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Wed, 10 Nov 2021 13:20:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Sean Rhodes
admin@starlabs.systems
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment