build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32097 )
Change subject: WIP: mediaek/mt8183: add panel driver for kukui p2 ......................................................................
Patch Set 3:
(40 comments)
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... File src/mainboard/google/kukui/mainboard.c:
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 77: gpio_set_pull(GPIO(MISC_BSI_CK_3), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 78: gpio_set_pull(GPIO(PERIPHERAL_EN9), GPIO_PULL_ENABLE, GPIO_PULL_UP); line over 80 characters
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 113: {INIT_DCS_CMD, 1, {MIPI_DCS_EXIT_SLEEP_MODE}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 115: {INIT_DCS_CMD, 1, {MIPI_DCS_SET_DISPLAY_ON}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 136: {INIT_GENENIC_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 139: {INIT_GENENIC_CMD, 6, {0x00, 0x08, 0x01, 0xf4, 0x01, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 141: {INIT_GENENIC_CMD, 6, {0x00, 0x0c, 0x00, 0x00, 0x00, 0x03}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 144: {INIT_GENENIC_CMD, 6, {0x00, 0x14, 0x0c, 0x3d, 0x80, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 145: {INIT_GENENIC_CMD, 6, {0x00, 0x20, 0x15, 0x92, 0x56, 0x7d}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 146: {INIT_GENENIC_CMD, 6, {0x00, 0x24, 0x00, 0x00, 0x30, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 148: {INIT_GENENIC_CMD, 6, {0x10, 0x08, 0x01, 0x20, 0x04, 0x45}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 149: {INIT_GENENIC_CMD, 6, {0x10, 0x1c, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 150: {INIT_GENENIC_CMD, 6, {0x20, 0x0c, 0x00, 0x00, 0x00, 0x04}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 152: {INIT_GENENIC_CMD, 6, {0x20, 0x10, 0x00, 0x4b, 0x00, 0x49}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 153: {INIT_GENENIC_CMD, 6, {0x20, 0xa0, 0x00, 0x00, 0x00, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 155: {INIT_GENENIC_CMD, 6, {0x60, 0x08, 0x00, 0xd9, 0x00, 0x08}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 156: {INIT_GENENIC_CMD, 6, {0x60, 0x14, 0x01, 0x00, 0x01, 0x06}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 158: {INIT_GENENIC_CMD, 6, {0x60, 0x80, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 160: {INIT_GENENIC_CMD, 6, {0x60, 0xa0, 0x00, 0x00, 0x00, 0x0f}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 163: {INIT_GENENIC_CMD, 6, {0x60, 0x0c, 0x0c, 0x50, 0x02, 0x18}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 165: {INIT_GENENIC_CMD, 6, {0x60, 0x10, 0x08, 0x00, 0x14, 0x50}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 167: {INIT_GENENIC_CMD, 6, {0x60, 0x84, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 168: {INIT_GENENIC_CMD, 6, {0x60, 0xa4, 0x00, 0x00, 0x03, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 171: {INIT_GENENIC_CMD, 2, {0xff, 0x01}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 172: {INIT_DCS_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 173: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 174: {INIT_DCS_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 175: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 176: {INIT_GENENIC_CMD, 2, {0xff, 0x00}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 178: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 179: {INIT_DCS_CMD, 1, {0x11}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 180: {DELAY_CMD, 120, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 181: {INIT_DCS_CMD, 1, {0x29}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 182: {DELAY_CMD, 20, {}}, space required after that close brace '}'
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 208: false, &edid, lcm_init_cmd, sizeof(lcm_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/3/src/mainboard/google/kukui/mainboard... PS3, Line 211: false, &edid, lcm_p097pfg_ssd2858_init_cmd, sizeof(lcm_p097pfg_ssd2858_init_cmd) / sizeof(struct lcm_init_table)); line over 80 characters
https://review.coreboot.org/#/c/32097/3/src/soc/mediatek/mt8183/dsi.c File src/soc/mediatek/mt8183/dsi.c:
https://review.coreboot.org/#/c/32097/3/src/soc/mediatek/mt8183/dsi.c@357 PS3, Line 357: while(read32(&dsi->dsi_intsta) & (1 << 31)) { space required before the open parenthesis '('
https://review.coreboot.org/#/c/32097/3/src/soc/mediatek/mt8183/dsi.c@358 PS3, Line 358: printk(BIOS_ERR, "mtk_dsi_cmdq wait dsi no busy\n"); Prefer using '"%s...", __func__' to using 'mtk_dsi_cmdq', this function's name, in a string
https://review.coreboot.org/#/c/32097/3/src/soc/mediatek/mt8183/dsi.c@385 PS3, Line 385: dsi_clrsetbits_le32((void *)DSI_BASE + 0x200 + ((cmdq_off + i) & (0xfffffffc)), line over 80 characters
https://review.coreboot.org/#/c/32097/3/src/soc/mediatek/mt8183/dsi.c@425 PS3, Line 425: printk(BIOS_ERR, "INIT_DCS_CMD Len should not be 0. INIT_DCS_CMD : init_cmd[%d].data[0] = 0x%x\n", init_cmd[i].data[0]); line over 80 characters