[coreboot-gerrit] Change in ...coreboot[master]: rockchip: rk3399: increase heap and memory for fit payload.

[Marty E. Plummer (Code Review)]

Marty E. Plummer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32373 )

Change subject: rockchip: rk3399: increase heap and memory for fit payload.
......................................................................

Patch Set 1:
> Patch Set 1:
>
> I don't think the Kconfig change belongs here since there's nothing Rockchip-specific about it... it's just that the FIT code may use a lot more heap than the coreboot default expects.
>
> How about we just change src/Kconfig to read
>
> config HEAP_SIZE
>    hex
>    default 0x100000 if FLATTENED_DEVICE_TREE
>    default 0x4000
>
> ? Then it works for all boards that enable FIT support out of the box.
>
> You can still submit a separate change to increase the ramstage in rk3399's memlayout, that doesn't hurt anyone.

So remove the Kconfig edit on this patchset and do another for the HEAP_SIZE in the 'global' kconfig?