Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46390 )
Change subject: soc/mediatek/mt8192: Add auxadc driver
......................................................................
Patch Set 21:
Patch Set 19:
(1 comment)
The implementation looks exactly the same as the one in 8183.
Please move 8183 to common/ and share it for both 8183 and 8192 (you may need to move some registers to include/soc).
Po Xu will submit a new patchset for reusing 8183 auxadc driver.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46390
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id4553e99c3578fa40e28b19a6e010b52650ba41e
Gerrit-Change-Number: 46390
Gerrit-PatchSet: 21
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Po Xu
jg_poxu@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Hung-Te Lin
hungte@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 11 Nov 2020 05:39:02 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment