Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Kapil Porwal, Kun Liu, Tarun.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79320?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/rex/var/screebo: Add delay 1ms after Main 3V3
......................................................................
Patch Set 1:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/79320/comment/4b53d872_1111cbe0 :
PS1, Line 12: when S0ix returns S0, PERST needs to delay until
: Main 3V3 is stable and then pull up
This should go into the main body of the commit message.
https://review.coreboot.org/c/coreboot/+/79320/comment/7baa78f6_fc15076c :
PS1, Line 12: PERST needs to delay until
: Main 3V3 is stable
Why? According to the schematics? Why 1 ms and not 3 or 5?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79320?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I33a86e52fab3c5c8cba6ebed0cbdd1b88b6538b0
Gerrit-Change-Number: 79320
Gerrit-PatchSet: 1
Gerrit-Owner: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eran Mitrani
mitrani@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rui Zhou
zhourui@huaqin.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun
tstuli@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eran Mitrani
mitrani@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Tarun
tstuli@gmail.com
Gerrit-Comment-Date: Thu, 30 Nov 2023 14:27:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment