Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46506 )
Change subject: drivers/uart: Fix control flow DEADCODE issue ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46506/4/src/drivers/uart/acpi/acpi.... File src/drivers/uart/acpi/acpi.c:
https://review.coreboot.org/c/coreboot/+/46506/4/src/drivers/uart/acpi/acpi.... PS4, Line 81: acpi_device_write_interrupt(&config->irq); From https://doc.coreboot.org/coding_style.html#placing-braces-and-spaces:
This does not apply if only one branch of a conditional statement is a single statement; in the latter case use braces in both branches: