Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45341 )
Change subject: soc/intel/common/block/cse: Refactor cse_request_global_reset() function ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/45341/3/src/soc/intel/common/block/... File src/soc/intel/common/block/cse/cse.c:
https://review.coreboot.org/c/coreboot/+/45341/3/src/soc/intel/common/block/... PS3, Line 618: static I don't think its a problem right now but if we ever have to support CSE only reset using this command, then we might have to add another helper or remove the static here.
https://review.coreboot.org/c/coreboot/+/45341/3/src/soc/intel/common/block/... PS3, Line 663: The reset type can be GLOBAL_RESET/CSE_RESET_ONLY This does not apply to cse_request_global_reset(). I think this whole comment should stay with cse_request_reset above.
https://review.coreboot.org/c/coreboot/+/45341/3/src/soc/intel/common/block/... File src/soc/intel/common/block/include/intelblocks/cse.h:
https://review.coreboot.org/c/coreboot/+/45341/3/src/soc/intel/common/block/... PS3, Line 125: The reset type can be one of the above defined reset type. No longer true.