Attention is currently required from: V Sowmya, Martin Roth, Tim Wawrzynczak, Balaji Manigandan, Aamir Bohra.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49731 )
Change subject: mb/intel/shadowmountain: Add the romstage code
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
File src/mainboard/intel/shadowmountain/variants/baseboard/memory.c:
https://review.coreboot.org/c/coreboot/+/49731/comment/d3227bc0_f9faaa7d
PS4, Line 8: /* DQ CPU<>DRAM map */
nit: this comment refers to `.lpx_dq_map`, should be moved downwards
https://review.coreboot.org/c/coreboot/+/49731/comment/be3d98ed_4a395f7e
PS4, Line 74: gpio_t spd_gpios[] = {
could this array be const?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49731
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ifd0bbcea9d4916d82bb1e3c275dd79d97a79727a
Gerrit-Change-Number: 49731
Gerrit-PatchSet: 4
Gerrit-Owner: V Sowmya
v.sowmya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: V Sowmya
v.sowmya@intel.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Thu, 18 Feb 2021 09:53:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment