Attention is currently required from: Keith Hui. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41735 )
Change subject: sb/intel/i82371eb: Implement SMBus Control Method Interface support ......................................................................
Patch Set 8: Code-Review+1
(2 comments)
File src/southbridge/intel/i82371eb/acpi/smbus.asl:
https://review.coreboot.org/c/coreboot/+/41735/comment/c47b1aa6_c2a1bb08 PS8, Line 7: /* Should have been SMBUS01, but Intel iasl won't accept */ That's because `SMBUS01` is not a valid ACPI HID. `SMB0001` at least conforms to the required format, but I'm not sure if it's an official HID.
There's also the `EisaId` method in ASL, not sure if it's needed here.
https://review.coreboot.org/c/coreboot/+/41735/comment/41073a9a_749fd5d5 PS8, Line 25: Your board may need adjustment How would one do this adjustment?