Daisuke Nojiri has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31626 )
Change subject: google_chromeec_command: makes the error status consistent
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/31626/1/src/ec/google/chromeec/ec.h
File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/#/c/31626/1/src/ec/google/chromeec/ec.h@164
PS1, Line 164: @return 0 on success or negative integer for errors.
Yes, updating the comment seems fine.
Sorry it was ambiguous. I was referring to this entire patch. Do we have a plan to use positive integers for something else?
As long as we know we won't break any board, it's ok to do this change now (sparing positive integers for future use) but currently the risk isn't worth.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31626
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I39f12502bc6982670dd200dcef0724e7eed2ed29
Gerrit-Change-Number: 31626
Gerrit-PatchSet: 2
Gerrit-Owner: YH Lin
yueherngl@google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daisuke Nojiri
dnojiri@chromium.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: YH Lin
yueherngl@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Wed, 27 Feb 2019 19:48:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Daisuke Nojiri
dnojiri@chromium.org
Comment-In-Reply-To: YH Lin
yueherngl@google.com
Gerrit-MessageType: comment