Attention is currently required from: Stefan Ott, Damien Zammit, Evgeny Zinoviev, Alexander Couzens, Patrick Rudolph.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58393 )
Change subject: cpu/intel/speedstep: Constify `get_cst_entries()`
......................................................................
Patch Set 1:
(1 comment)
File src/include/acpi/acpigen.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-130704):
https://review.coreboot.org/c/coreboot/+/58393/comment/8be8da84_cc5ad437
PS1, Line 502: int get_cst_entries(const acpi_cstate_t **);
function definition argument 'const acpi_cstate_t **' should also have an identifier name
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58393
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib22b3e37b086a95af770465a45222e9b84202e54
Gerrit-Change-Number: 58393
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Evgeny Zinoviev
me@ch1p.io
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Stefan Ott
coreboot@desire.ch
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Ott
coreboot@desire.ch
Gerrit-Attention: Damien Zammit
Gerrit-Attention: Evgeny Zinoviev
me@ch1p.io
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Sun, 17 Oct 2021 12:18:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment