[coreboot-gerrit] [M] Change in coreboot[main]: lib: Refactor ux_locales_get_text API

[Julius Werner (Code Review)]

Attention is currently required from: Dinesh Gehlot, Eran Mitrani, Intel coreboot Reviewers, Jakub "Kuba" Czapiga, Jayvik Desai, Jérémy Compostella, Kapil Porwal, Nick Vaccaro, Subrata Banik, Tarun.

Julius Werner has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86283?usp=email )

Change subject: lib: Refactor ux_locales_get_text API
......................................................................

Patch Set 8:

(1 comment)

File src/include/ux_locales.h:

https://review.coreboot.org/c/coreboot/+/86283/comment/3fdc6ae6_832f5ac5?usp... :
PS5, Line 23: const char *ux_locales_get_text(const char *name, const char *fallback_text);
> > Well, then change the test, of course. […]

I don't think we should keep tests for an API that we do not want to expose for anyone to call anymore. Also, removing the other function may make the implementation of the `by_id()` function simpler (because then it will just be integrated into the main function and not be a separate thing), and it will also mean we would probably just call it `ux_locales_get_text()`, without the `_by_id`, because then that's the only option.

In general, the development flow should always start with deciding how you want the code to work at the high level, then designing the APIs that connect the different pieces, then implementing each of those individual parts, and then writing/adjusting unit tests for them. You should never turn that process around and e.g. have your decision of how to design an API influenced by how existing unit tests are written. The unit tests are there to support the code, not the other way round.