Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40223 )
Change subject: mb/google/hatch: Add Duffy variant ......................................................................
Patch Set 1: Code-Review+1
(3 comments)
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/gpio.c:
PS1: Please use SPDX:
/* SPDX-License-Identifier: GPL-2.0-only */ /* This file is part of the coreboot project. */
Applies to all files
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/mainboard.c:
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... PS1, Line 50: gpio_configure_pads. */ nit: this line and the first `if` fit in one line
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/duffy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40223/1/src/mainboard/google/hatch/... PS1, Line 295: # VR Settings Configuration for 4 Domains I think vr_config.c takes care of these automatically now