Attention is currently required from: Reka Norman, Maulik V Vaghela, Paul Menzel, Rizwan Qureshi, Subrata Banik, Sridhar Siricilla, Krishna P Bhat D, Usha P, Patrick Rudolph, Kangheui Won.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59751 )
Change subject: soc/intel/alderlake: Add Kconfig for ADL_N PCH
......................................................................
Patch Set 2:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/59751/comment/1276d210_e7ec5c9b
PS1, Line 14: Choose this option if you have PCH-N chipset.
This is a config to control the compilation specific to ADL-N. […]
It would introduce lots of unnecessary complexity. Mainboards only use one type of PCH and it's always the same, so this is a compile-time constant. Yes, someone could choose the wrong PCH type when adding a new mainboard, but that would be their problem.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/59751
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1be10aea36db5a14ca8d7cf5c087163e44554f78
Gerrit-Change-Number: 59751
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Kangheui Won
khwon@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Reka Norman
rekanorman@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Reka Norman
rekanorman@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Usha P
usha.p@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Kangheui Won
khwon@google.com
Gerrit-Comment-Date: Wed, 01 Dec 2021 13:06:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Usha P
usha.p@intel.com
Gerrit-MessageType: comment