23 Dec
2019
23 Dec
'19
2:18 a.m.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37907 )
Change subject: mainboard/google/hatch: Move da7219 drv into Kohaku ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37907/2/src/mainboard/google/hatch/... File src/mainboard/google/hatch/Kconfig:
https://review.coreboot.org/c/coreboot/+/37907/2/src/mainboard/google/hatch/... PS2, Line 6: DRIVERS_I2C_DA7219 Selecting this should be harmless. If it goes unused, it gets dropped by the linker. Are you running into any issue with this being selected?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37907
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7d803b5cb53daea5bbd16818aaecaf8e0970c505
Gerrit-Change-Number: 37907
Gerrit-PatchSet: 2
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@chromium.org
Gerrit-Reviewer: Daniel Kurtz djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-Comment-Date: Mon, 23 Dec 2019 10:18:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment