Attention is currently required from: Jamie Chen, Henry Sun, shkim, SH Kim.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49791 )
Change subject: mb/google/dedede/var/sasuke: Configure GPP_G7 as native
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/dedede/variants/sasuke/gpio.c:
https://review.coreboot.org/c/coreboot/+/49791/comment/48bde189_751bed7c
PS2, Line 52: PAD_NC(GPP_G7, NONE),
Put my comment on the tracker. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49791
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If73337b482f04fd263caaa6fed0e54aa87bd876e
Gerrit-Change-Number: 49791
Gerrit-PatchSet: 2
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jamie Chen
jamie.chen@intel.corp-partner.google.com
Gerrit-Attention: Jamie Chen
jamie.chen@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: shkim
sh_.kim@samsung.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Tue, 26 Jan 2021 16:42:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jamie Chen
jamie.chen@intel.com
Comment-In-Reply-To: Henry Sun
henrysun@google.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment