build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45658 )
Change subject: Port of Kontron bSC2 COMe module ......................................................................
Patch Set 1:
(24 comments)
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/Kconfig:
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 48: trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/acpi/superio.asl:
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 50: IQ01, 8, trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 47: device pci 16.1 off end # Management Engine Interface 2 trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 88: io 0x62 = 0x64 trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/early_init.c:
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 33: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1403); /* COMA, COMB, KBC and LPC 0x2E enabled */ trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 33: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x82, 0x1403); /* COMA, COMB, KBC and LPC 0x2E enabled */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 34: pci_write_config16(PCI_DEV(0, 0x1f, 0), 0x80, 0x0010); /* LPC decode ranges COMA=3F8, COMB=2F8 */ line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... File src/mainboard/kontron/bSC2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 41: #define adt7490_write_byte(reg, val) do_smbus_write_byte(smbus_io_base, adt7490_address, reg, val) line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 101: if ((vendid = 0x41) && // Analog Devices code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 101: if ((vendid = 0x41) && // Analog Devices please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 101: if ((vendid = 0x41) && // Analog Devices do not use assignment in if condition
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 102: (devid2 & 0xfc) == 0x6c) { // Device ID code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 102: (devid2 & 0xfc) == 0x6c) { // Device ID please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 108: adt7490_write_byte(CONF_REG_1, 0x15); // Monitoring and PWM control outputs enabled line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 109: adt7490_write_byte(PWM1_CONF_REG, 0x42); // 250ms spin time, Remote 2 temp. controls PWM1 line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 110: adt7490_write_byte(R2_TRAN_PWM3_FREQ, 0xB4); // Frequency = 35.3 Hz, low frequency PWM mode, trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 110: adt7490_write_byte(R2_TRAN_PWM3_FREQ, 0xB4); // Frequency = 35.3 Hz, low frequency PWM mode, line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 112: adt7490_write_byte(PWM1_MIN_DUTY_CYCLE, 0x54); trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 114: adt7490_write_byte(R2_TEMP_TMIN, 0x37); // When the temperature measured exceeds T MIN , the trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 114: adt7490_write_byte(R2_TEMP_TMIN, 0x37); // When the temperature measured exceeds T MIN , the line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 115: // appropriate fan runs at minimum speed and trailing whitespace
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 115: // appropriate fan runs at minimum speed and line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 116: // increases with temperature according to T RANGE. line over 96 characters
https://review.coreboot.org/c/coreboot/+/45658/1/src/mainboard/kontron/bSC2/... PS1, Line 119: adt7490_write_byte(THERM_TIMER_LIMIT, 0xFF); // Avoid unwanted alerts from being generated. line over 96 characters