Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37901 )
Change subject: mb/google/kefka: Add missing SPD
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v...
File src/mainboard/google/cyan/variants/kefka/spd_util.c:
https://review.coreboot.org/c/coreboot/+/37901/1/src/mainboard/google/cyan/v...
PS1, Line 33: static const uint32_t dual_channel_config =
lint yelled at me so I changed it :)
The lint on your machine? Maybe it needs to be updated. Meh, not a big deal
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37901
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0ae76c4d8313246927bbc3f71b21f3611c89a6e3
Gerrit-Change-Number: 37901
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 26 Dec 2019 11:48:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Gerrit-MessageType: comment