Jett Rink has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35239 )
Change subject: hatch: automate creating a new variant in coreboot ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/scripts/create_coreboot_variant.sh:
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 34: echo <<EOF >variants/${variant,,}/include/variant/acpi/dptf.asl it feels a little weird for all of the templates to live in this script. Can we look at using separate template files instead? Does coreboot already have and code generation stuff?
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 38: 2019 We will want this date to update
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 119: # should these be source code comments instead?
https://review.coreboot.org/c/coreboot/+/35239/1/src/mainboard/google/hatch/... PS1, Line 136: git add KConfig KConfig.name : : # Now commit the files : git commit -m "${base,,}: Create ${variant,,} variant : : BUG=none : TEST=util/abuild/abuild -p none -t google/${base,,} -x -a : make sure the build includes GOOGLE_{variant^^} : : Signed-off-by: ${name} <${email}>" I don't think we need to add the git logic to the script. Let's just create the files in the working directory