24 Sep
2020
24 Sep
'20
1:55 p.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44476 )
Change subject: ec/kontron/kempld: add option to configure I2C frequency ......................................................................
Patch Set 12: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/44476/12/src/ec/kontron/kempld/kemp... File src/ec/kontron/kempld/kempld_i2c.c:
https://review.coreboot.org/c/coreboot/+/44476/12/src/ec/kontron/kempld/kemp... PS12, Line 50: stadart ?
Plus, if you indicate these are in kHz, the comments can go away
https://review.coreboot.org/c/coreboot/+/44476/12/src/ec/kontron/kempld/kemp... PS12, Line 262: is an invalid frequency value "is too high"?
--
To view, visit https://review.coreboot.org/c/coreboot/+/44476
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If0eb477af10d00eb4f17f9c01209f170b746ad3d
Gerrit-Change-Number: 44476
Gerrit-PatchSet: 12
Gerrit-Owner: Maxim Polyakov max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Andrey Petrov andrey.petrov@gmail.com
Gerrit-Reviewer: Andrey Petrov anpetrov@fb.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 24 Sep 2020 11:55:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment