Attention is currently required from: Subrata Banik, Tim Wawrzynczak, Nick Vaccaro, Arthur Heymans, Eric Lai. Hello build bot (Jenkins), Tim Wawrzynczak, Nick Vaccaro, Angel Pons, Arthur Heymans, Nick Vaccaro, Lean Sheng Tan, Eric Lai,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/63518
to look at the new patch set (#3).
Change subject: soc/intel/common/{sa, adl}: Add `finalize` operation for systemagent ......................................................................
soc/intel/common/{sa, adl}: Add `finalize` operation for systemagent
This patch implements the required operations to perform prior to booting to OS using coreboot native driver when platform decides to skip FSP notify APIs i.e. End Of Firmware.
The system agent `.final` operation ensures locking the PAM register hence, skip dedicated calling into `sa_lock_pam()` from the SoC `finalize.c` file when coreboot decides to skip FspNotifyApi() calls.
BUG=b:211954778 TEST=Able to build google/brya with these changes and coreboot log with this code change as below with ADL SoC skip calling into FspNotifyAPIs:
[INFO ] Finalize devices... [DEBUG] PCI: 00:00.0 final
localhost ~ # lspci -xxx | less
00:00.0 Host bridge: Device 8086:4601 (rev 04)
Bit 0 for all PAM registers a.k.a, PAMx_0_0_0_PCI.LOCK bit is set (meaning locked).
Signed-off-by: Subrata Banik subratabanik@google.com Change-Id: Ibd464d2507393ed0c746eb1fbd10e36092ed5599 --- M src/soc/intel/alderlake/finalize.c M src/soc/intel/common/block/systemagent/systemagent.c 2 files changed, 17 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/63518/3