Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43745 )
Change subject: mb/google/dedede/var/madoo: Configure GPIO for Madoo
......................................................................
Patch Set 8: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede...
File src/mainboard/google/dedede/variants/madoo/gpio.c:
https://review.coreboot.org/c/coreboot/+/43745/3/src/mainboard/google/dedede...
PS3, Line 9: PAD_CFG_NF(GPP_A13, NONE, DEEP, NF1),
It just for USB overcurrent.
All the USB over current events are handled at the EC and not at the AP. So I am not sure if it needs to be routed to AP. I do not want to block this change for this reason. But please do revisit this GPIO later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I85aadfb0d020055eec921c7646c16ae6c95a606f
Gerrit-Change-Number: 43745
Gerrit-PatchSet: 8
Gerrit-Owner: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marco Chen
marcochen@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Lee
alan_lee@compal.corp-partner.google.com
Gerrit-CC: Ian Feng
ian_feng@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 24 Jul 2020 17:16:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment