Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35542 )
Change subject: soc/intel/skylake: devicetree: introduce PchHdaVcType fsp parameter ......................................................................
Patch Set 12: Code-Review+1
(4 comments)
Thank you for this contribution
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/asrock/h110m... File src/mainboard/asrock/h110m/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/asrock/h110m... PS12, Line 58: 0x01 "VC1"
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/intel/kblrvp... File src/mainboard/intel/kblrvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/intel/kblrvp... PS12, Line 33: 0x01 "VC1"
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151-series/variants/x11ssh-tf/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35542/12/src/mainboard/supermicro/x... PS12, Line 34: register "PchHdaVcType" = "0x01" register "PchHdaVcType" = "VC1"
https://review.coreboot.org/c/coreboot/+/35542/12/src/soc/intel/skylake/chip... File src/soc/intel/skylake/chip.h:
https://review.coreboot.org/c/coreboot/+/35542/12/src/soc/intel/skylake/chip... PS12, Line 210: u8 PchHdaVcType I think it would be better /* Virtual Channel Type Select */ enum { VC0, VC1, } PchHdaVcType;