Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38421 )
Change subject: commonlib/bsd: Add new CBFS core implementation ......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38421/5/src/commonlib/bsd/include/c... File src/commonlib/bsd/include/commonlib/bsd/cbfs_serialized.h:
https://review.coreboot.org/c/coreboot/+/38421/5/src/commonlib/bsd/include/c... PS5, Line 7: #include <vb2_sha.h>
Yes, all software that wants to build commonlib code may also need to build vboot. […]
I like the idea of having a shared code base, but in order to use it in 3rdparty apps we might need to move it to a single repo. Now that verification is an essential part of the cbfs itself it might make even more sense. The coreboot support for FWTS will make use of distros shipping coreboot-dev, and with a dependency to vboot-dev this seems even more unlikely to see a broad distribution.