Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47302 )
Change subject: soc/intel/xeon_sp: Synchronize DMAR and MADT IOAPIC id's
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/47302/2/src/soc/intel/xeon_sp/skx/s...
File src/soc/intel/xeon_sp/skx/soc_util.c:
https://review.coreboot.org/c/coreboot/+/47302/2/src/soc/intel/xeon_sp/skx/s...
PS2, Line 306: }
I don't know if PSTACK3/4 for MCP have IOAPICs. […]
Looking at the hob display, I'm convinced that this is ok. I think it would be better to use the hob to check personalities instead of hard coding, but this is correct for these cpus.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id504c2159066e6cddd01d30649921447bef17b12
Gerrit-Change-Number: 47302
Gerrit-PatchSet: 3
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 06 Nov 2020 22:46:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Marc Jones
marc@marcjonesconsulting.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment