Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44569 )
Change subject: soc/mediatek/mt8192: Do dram fast calibration
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44569/7/src/soc/mediatek/mt8192/mem...
File src/soc/mediatek/mt8192/memory.c:
https://review.coreboot.org/c/coreboot/+/44569/7/src/soc/mediatek/mt8192/mem...
PS7, Line 95: /* need to erase the flash data immediately when fast calibration fail */
line over 96 characters
Please address that.
/* Need to erase the flash data immediately when fast calibration
fail */
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44569
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45a4fedc623aecfd000c5860e0e85175f45b8ded
Gerrit-Change-Number: 44569
Gerrit-PatchSet: 7
Gerrit-Owner: CK HU
ck.hu@mediatek.com
Gerrit-Reviewer: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 08 Sep 2020 04:04:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-MessageType: comment