Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39346 )
Change subject: soc/intel/tigerlake: Add processor power limits control support ......................................................................
Patch Set 17:
(5 comments)
https://review.coreboot.org/c/coreboot/+/39346/17/src/mainboard/intel/glkrvp... File src/mainboard/intel/glkrvp/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/39346/17/src/mainboard/intel/glkrvp... PS17, Line 58: 7.5W setting gives a run-time 6W actual to what extent does this still hold?
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.h:
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... PS17, Line 115: mW just W
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... PS17, Line 117: mW W
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... File src/soc/intel/apollolake/chip.c:
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... PS17, Line 322: / 1000 really?
https://review.coreboot.org/c/coreboot/+/39346/17/src/soc/intel/apollolake/c... PS17, Line 342: %d does this need to be %02d?