[coreboot-gerrit] Change in ...coreboot[master]: mb/google/sarien: Turn off camera power when s0ix

[EricR Lai (Code Review)]

EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32519 )

Change subject: mb/google/sarien: Turn off camera power when s0ix
......................................................................

Patch Set 7:

(2 comments)

https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... 
File src/mainboard/google/sarien/variants/sarien/include/variant/acpi/mainboard.asl:

https://review.coreboot.org/#/c/32519/7/src/mainboard/google/sarien/variants... 
PS7, Line 21: /* Turn off camera power */
> Can this be done as part of MPTS: https://review.coreboot.org/c/coreboot/+/32366 […]

I can't find what Arg0 would be for s0ix in _PTS. I can't find it description in ACPI spec. If it has define, of course we can do that.

https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a... 
File src/soc/intel/cannonlake/acpi/lpit.asl:

https://review.coreboot.org/#/c/32519/7/src/soc/intel/cannonlake/acpi/lpit.a... 
PS7, Line 68: MS0X
> What does MS0X mean? Mainboard S0ix?

Yes, do you have a better idea? I am fine with this.