Attention is currently required from: Tarun Tuli, Henry Sun, Paul Menzel, Reka Norman, Shou-Chieh Hsu.
Lawrence Chang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69892 )
Change subject: mb/google/nissa/var/xivu: Fine-tune eMMC DLL ......................................................................
Patch Set 6:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69892/comment/faf927d1_86fa8904 PS2, Line 7: xivu
/var/xivu
modified it to mb/google/nissa/var/xivu
https://review.coreboot.org/c/coreboot/+/69892/comment/8ed52f9f_1260cab9 PS2, Line 7: nissa
Why not *brya*?
"brya" is ADL-P and "nissa" is ADL-N, and then Xivu is an ADL-N design based on nissa, hence I use "nissa", not "brya".
https://review.coreboot.org/c/coreboot/+/69892/comment/b7d83259_c95874b2 PS2, Line 7: value
values? […]
modified title to "Fine-tune eMMC DLL"
https://review.coreboot.org/c/coreboot/+/69892/comment/783ae631_abeb5f23 PS2, Line 9: Configure eMMC DLL tuning values for Xivu board.
Please add, where you got the values from.
To get eMMC passing window for each speed, I executed eMMC tuning tool on several Xivu systems, and then determine appropriate eMMC DLL settings based on the eMMC passing window we got from Xivu systems.
https://review.coreboot.org/c/coreboot/+/69892/comment/5a5491d3_dc5708de PS2, Line 12: TEST="Use the value to boot on Xivu successfully."
- Please remove the quotes. […]
Before fine-tuning eMMC DLL, execute cold boot 10 cycles, some systems may fail to boot from eMMC. After fine-tuning eMMC DLL and executing 3000 cycles of cold boot, issue is not observed.