Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39286 )
Change subject: drivers/generic/max98357a: Allow custom _HID from config
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39286/12//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39286/12//COMMIT_MSG@7
PS12, Line 7: max98357a
Not all maxim chips are pin-compatible with max98357a eg. max98373.
How are these pin incompatible chips handled by the kernel? Do their drivers require similar information in ACPI tables i.e. SD mode gpio and delay? or is the information very different?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39286
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I22d2d078a9a4eb6ab330da8439737ff5133086d4
Gerrit-Change-Number: 39286
Gerrit-PatchSet: 12
Gerrit-Owner: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: Divagar Mohandass
divagar.mohandass@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh
furquan@google.com
Gerrit-CC: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 17 Mar 2020 19:53:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment