Nick Vaccaro has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75533?usp=email )
Change subject: mb/google/brya/acpi: Turn NV12 enable signal off on GCOFF entry ......................................................................
mb/google/brya/acpi: Turn NV12 enable signal off on GCOFF entry
Properly shutdown NV12 rail in the off sequence (current implementation leaves it asserted).
BUG=b:286287940 TEST=NV12 now shuts down on GCOFF entry Change-Id: I7d338fc4a96f119617aff558413a5a9ac44c27d7 Signed-off-by: Tarun Tuli taruntuli@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/75533 Reviewed-by: Eran Mitrani mitrani@google.com Reviewed-by: Eric Lai eric_lai@quanta.corp-partner.google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nick Vaccaro nvaccaro@google.com --- M src/mainboard/google/brya/acpi/power.asl 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Eran Mitrani: Looks good to me, approved build bot (Jenkins): Verified Eric Lai: Looks good to me, approved Nick Vaccaro: Looks good to me, approved
diff --git a/src/mainboard/google/brya/acpi/power.asl b/src/mainboard/google/brya/acpi/power.asl index c4a8495..5638e18 100644 --- a/src/mainboard/google/brya/acpi/power.asl +++ b/src/mainboard/google/brya/acpi/power.asl @@ -312,7 +312,7 @@ GPPL (GPIO_1V8_PG, 0, 20)
/* Ramp down 1.2V rail on boards with support */ - STXS (GPIO_NV12_PWR_EN) + CTXS (GPIO_NV12_PWR_EN) GPPL (GPIO_NV12_PG, 0, 5)
GCOT = Timer