Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37069 )
Change subject: trogdor: add support for Bubs variant
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo...
File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/37069/1/src/mainboard/google/trogdo...
PS1, Line 40: default 0xa
And this needs to be 0x8
Sorry: 0x6, not 0x8. I only just now realized that SC7180 has fewer QUPs per WRAP than SDM845 had.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d9bc98863c4f33c19e295b642f48c51921ed984
Gerrit-Change-Number: 37069
Gerrit-PatchSet: 1
Gerrit-Owner: mturney mturney
mturney@codeaurora.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Douglas Anderson
dianders@chromium.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Comment-Date: Thu, 21 Nov 2019 21:49:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment