Attention is currently required from: Raul Rangel.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68913 )
Change subject: cpu/x86: Set up cpu_info storage using MSR
......................................................................
Patch Set 5:
(2 comments)
File src/arch/x86/include/arch/cpu.h:
https://review.coreboot.org/c/coreboot/+/68913/comment/a4c3846b_789cb1e9
PS5, Line 156: (cpuid_edx(0x80000001) & (1 << 29)) != 0;
Make this a helper method so you don't need to duplicate it.
Done
https://review.coreboot.org/c/coreboot/+/68913/comment/3bdf5439_0b1f5758
PS5, Line 159: msr_t msr = rdmsr(IA32_GS_BASE);
: ci = (struct cpu_info *)(uintptr_t)msr.raw;
: return ci;
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68913
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id38d3c84ef757c0b322ec0d387f57043147cb447
Gerrit-Change-Number: 68913
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Fri, 11 Nov 2022 14:20:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Gerrit-MessageType: comment