Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34939 )
Change subject: Add new ENV_xxx definitions
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/stddef.h
File src/include/stddef.h:
https://review.coreboot.org/c/coreboot/+/34939/5/src/include/stddef.h@52
PS5, Line 52: #define ALLOC_LARGE_BUFFER MAYBE_BSS
Aaron should comment, his suggestion.
Is there ever a case where we want that buffer on the stack? ramstage? and CAR_GLOBAL_MIGRATION platforms?
We either hide it or put all that logic in the compilation unit itself. I don't care either way. MAYBE_STATIC was being utilized before which isn't super explicit either in its semantics.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34939
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibd2292f922ccb9e79d10ca9bc35797048d174287
Gerrit-Change-Number: 34939
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Tue, 20 Aug 2019 02:10:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment