Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40251 )
Change subject: mb/google/dedede: Enable ELAN touch screen for Waddledoo ......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... File src/mainboard/google/dedede/variants/waddledoo/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... PS6, Line 87: "280" I think the values in stop_delay_ms and stop_off_delay_ms needs to be swapped.
As per the description for these parameters: stop_delay_ms - Delay to be inserted after disabling stop. stop_off_delay_ms - Delay to be inserted after enabling stop.
As per the datasheet, after enabling stop/report line all the I2C commands/transactions should start only after 280 ms. Also after disabling stop/report, host should wait 2 ms before toggling any other signal.
https://review.coreboot.org/c/coreboot/+/40251/6/src/mainboard/google/dedede... PS6, Line 91: 10 Why is 10 ms required? If I am reading the datasheet correctly 1 ms is good, unless I am looking at the wrong line.