Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30889 )
Change subject: autoport: move the generated gnvs.c to acpi_tables.c
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go
File util/autoport/bd82x6x.go:
https://review.coreboot.org/#/c/30889/1/util/autoport/bd82x6x.go@418
PS1, Line 418:
It would be good to remove this extra newline too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/30889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8f6eea579f69060608639b1c50255acd8ab5a4a2
Gerrit-Change-Number: 30889
Gerrit-PatchSet: 1
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Tristan Corrick
tristan@corrick.kiwi
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 14 Jan 2019 09:52:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment