[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede/var/bugzzy: Initialize display signals on user mode

[SH Kim (Code Review)]

Attention is currently required from: shkim, Henry Sun, Evan Green, Tim Wawrzynczak, Paul Menzel, Simon Yang, Edward Doan, Karthik Ramasubramanian.
SH Kim has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60190 )

Change subject: mb/google/dedede/var/bugzzy: Initialize display signals on user mode
......................................................................

Patch Set 13:

(6 comments)

File src/mainboard/google/dedede/variants/bugzzy/ramstage.c:

https://review.coreboot.org/c/coreboot/+/60190/comment/6ab9a3fa_e2a17c09 
PS11, Line 26: if (display_init_required())
> `if (display_init_required() || !igd_dev)`

Done

https://review.coreboot.org/c/coreboot/+/60190/comment/cb744407_813ea6ca 
PS11, Line 29: pci_read_config32(igd_dev, PCI_BASE_ADDRESS_0) & 0xfffffff0;
> `mmio32 = find_resource(igd_dev, PCI_BASE_ADDRESS_0)->base;`

Done

https://review.coreboot.org/c/coreboot/+/60190/comment/c2a0728f_aa844bf6 
PS11, Line 32: addr32 = mmio32 + PCH_PP_CONTROL;
             : 	data32 = read32((void *) addr32);
             : 	data32 = data32 | 0x1;
             : 	write32((void *)addr32, data32);
             :
> This can be simplified to: […]

Done

https://review.coreboot.org/c/coreboot/+/60190/comment/15c01cf8_3278f1c4 
PS11, Line 40: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 |= GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
> Similarly […]

Done

https://review.coreboot.org/c/coreboot/+/60190/comment/0b3f1dea_8e2b5bd0 
PS11, Line 49: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 &= ~GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
>

Done

https://review.coreboot.org/c/coreboot/+/60190/comment/314fdd72_36bd6839 
PS11, Line 58: addr32 = mmio32 + PCH_GPIOB;
             : 	data32 = read32((void *) addr32);
             : 	data32 |= GPIO_CLOCK_VAL_OUT;
             : 	data32 |= GPIO_CLOCK_DIR_MASK | GPIO_CLOCK_DIR_OUT | GPIO_CLOCK_VAL_MASK;
             : 	write32((void *)addr32, data32);
> It might also be helpful to put these all into functions, e.g. […]

Thanks, it looks good.