Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39196 )
Change subject: jasperlake_rvp: Update UART config for JSLRVP
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jasper...
File src/mainboard/intel/jasperlake_rvp/Kconfig:
https://review.coreboot.org/c/coreboot/+/39196/11/src/mainboard/intel/jasper...
PS11, Line 53: default 0 if !INTEL_LPSS_UART_FOR_CONSOLE
this is good idea to support both UART is same build bt technically its not possible
even line #14 also doesn't make sense as chrome will always use LPSS uart better u only keep on support
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39196
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic042cdc449b77c2d9bdd7a63777328e47f910654
Gerrit-Change-Number: 39196
Gerrit-PatchSet: 11
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Varshit B Pandya
varshit.b.pandya@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 19 Mar 2020 15:08:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment