Christoph Pomaska has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38920 )
Change subject: [WIP] mb/gigabyte: Add Gigabyte Z170X-Gaming 7 ......................................................................
Patch Set 9:
(3 comments)
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/gpio.h:
https://review.coreboot.org/c/coreboot/+/38920/2/src/mainboard/gigabyte/ga-z... PS2, Line 25: static const struct pad_config gpio_table[] = {
The values have been retrieved from the board.
Done
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z... File src/mainboard/gigabyte/ga-z170x-gaming7/romstage.c:
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z... PS9, Line 24: const u16 RcompResistor[3] = { 200, 81, 162 };
They don't exist at all.
So I could remove the constant entirely?
https://review.coreboot.org/c/coreboot/+/38920/9/src/mainboard/gigabyte/ga-z... PS9, Line 33: 100, 40, 40, 23, 40 };
60, 26, 20, 20, 26
What about this one?