Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40501 )
Change subject: deltaur: Split up chromeos.fmd ......................................................................
Patch Set 1:
(4 comments)
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@7 PS1, Line 7: deltaur: Split up chromeos.fmd I’d describe the change in the summary, and not how it’s accomplished. Maybe:
mb/google/deltaur/variant/deltaur: Remove GbE FMAP region
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@7 PS1, Line 7: deltaur mb/google/…
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@9 PS1, Line 9: Deltan will use the GbE region, whereas deltaur will not. Why doesn’t it need the GbE region?
https://review.coreboot.org/c/coreboot/+/40501/1//COMMIT_MSG@15 PS1, Line 15: and use ifdtool -p tgl -t image-delta{ur,n}.bin to make sure FMAP aligns with IFWI Please wrap the line after 72/75 characters.