Eric Peers has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43308 )
Change subject: soc/amd/picasso: Init SPI speeds & mode in psp_verstage
......................................................................
Patch Set 3: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/43308/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/43308/3//COMMIT_MSG@14
PS3, Line 14: TEST=Build & boot. Verify that boot time decreases & that verstage
Per Matt's comment, "This shouldn't hurt anything"...
can you please test this on Morphius - just to make sure we're running ok there? I expect we will be given that we reverted the 100MHz, but worth checking. Otherwise +1 from me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43308
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iebf3ed3f5d6be0dda717d91d5b2fbcf2a1cc43cc
Gerrit-Change-Number: 43308
Gerrit-PatchSet: 3
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Eric Peers
epeers@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Matt Papageorge
matthewpapa07@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Rob Barnes
robbarnes@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 16 Jul 2020 16:57:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment