Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34433 )
Change subject: mediatek/mt8183: support get current DRAM type
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc...
File src/soc/mediatek/mt8183/include/soc/emi.h:
https://review.coreboot.org/c/coreboot/+/34433/3/src/soc/mediatek/mt8183/inc...
PS3, Line 36: enum {
: DRAM_TYPE_DISCRETE,
: DRAM_TYPE_EMCP,
: };
move this before 'struct sdram_parms, and make type, i..e,
enum DRAM_TYPE {
DRAM_TYPE_DISCRETE,
...
};
struct sdram_params {
enum DRAM_TYPE dram_type;
u32 impedance[2][4]; ...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34433
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icf875427347418f796cbf193070bf047844d2267
Gerrit-Change-Number: 34433
Gerrit-PatchSet: 3
Gerrit-Owner: huayang duan
huayangduan@gmail.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Sj Huang
sj.huang@mediatek.com
Gerrit-Reviewer: You-Cheng Syu
youcheng@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: huayang duan
huayangduan@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 23 Jul 2019 02:39:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment