[coreboot-gerrit] Change in coreboot[master]: soc/amd/picasso: Add northbridge pci driver

[Aaron Durbin (Code Review)]

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34424 )

Change subject: soc/amd/picasso: Add northbridge pci driver
......................................................................

Patch Set 26:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... 
File src/soc/amd/picasso/northbridge.c:

https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... 
PS26, Line 18: 0x10
What was 0x10 chosen here?

https://review.coreboot.org/c/coreboot/+/34424/26/src/soc/amd/picasso/northb... 
PS26, Line 67: 	char pscope[] = "\_SB.PCI0";
acpi_device_scope() is more correct. so one would just call the following on line 69:

acpigen_write_scope(acpi_device_scope(device));